[IMP] Pin chromium to specific version following OCA Chrome - #720
Draft
david-banon-tecnativa wants to merge 2 commits into
Draft
[IMP] Pin chromium to specific version following OCA Chrome#720david-banon-tecnativa wants to merge 2 commits into
david-banon-tecnativa wants to merge 2 commits into
Conversation
Instead of obtaining chromium from the apt repos, we download a specific version from the chromium build archive. This way, we can use a semi equivalent version to the google-chrome used in the OCA, See https://github.com/OCA/oca-ci/blob/master/Dockerfile#L97
|
Test this PR by using this tag: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Instead of obtaining chromium from the apt repos, we download a specific version from the chromium build archive.
This way, we can use a semi equivalent version to the google-chrome used in the OCA, See https://github.com/OCA/oca-ci/blob/master/Dockerfile#L97
This is the second atempt, the first one got reverted becuase due to a ci mistake, tests were passing when they shouldn't
Why:
To avoid test problems derived from using a different chromium version than OCA.
Versions affected:
15.0+
11.0 and 12.0 should remain frozen
13.0 and 14.0 weren't behaving when isntalling the chromium dependencies.